Pass callback to get provider options to provider_v26 constructor#244
Merged
Pass callback to get provider options to provider_v26 constructor#244
Conversation
temeo
force-pushed
the
provider_options_cb
branch
from
d9b44fa to
1b7acab
Compare
sciascid
force-pushed
the
provider_options_cb
branch
from
a2c1a51 to
9349f85
Compare
sciascid
force-pushed
the
provider_options_cb
branch
2 times, most recently
from
a8222d8 to
db41d67
Compare
sciascid
force-pushed
the
provider_options_cb
branch
2 times, most recently
from
de9935c to
c8f25d4
Compare
temeo
commented
May 19, 2025
temeo
commented
Jun 2, 2025
| wsrep_status_t ret = wsrep_config_service_v2::service.get_parameters( | ||
| wsrep, &wsrep_config_service_v2::service_callback, options); | ||
|
|
||
| config_service_v2_deinit(wsrep->dlh); |
Contributor
Author
There was a problem hiding this comment.
Why is config service v2 deinitialized immediately after getting parameters? Is there some reason which would require explanation in comments?
There was a problem hiding this comment.
Function config_service_v1_fetch() provides this convenience that initializes the service, invokes it, and then de-initializes it. The config service is used only one time. Same happens with v1.
sciascid
force-pushed
the
provider_options_cb
branch
from
91cc211 to
b491197
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
temeo
commented
Jul 9, 2025
Contributor
Author
temeo
left a comment
temeo
left a comment
There was a problem hiding this comment.
Looks good. Please squash into one commit and refer MDEV-37026 in commit message.
sciascid
approved these changes
Jul 9, 2025
Passing a callback allows constructing the options string using config service after loading the provider but before initializing the provider. This way it is possible get options which are given at DBMS startup, in command line or config file.
sciascid
force-pushed
the
provider_options_cb
branch
from
b491197 to
3965d83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a callback allows constructing the options string using
config service after loading the provider but before initializing
the provider.